Skip to content

Commit

Permalink
Modules: don't install modules that this module is a substring of.
Browse files Browse the repository at this point in the history
All fixed with a single forward slash!

Closes nf-core#1380
  • Loading branch information
ewels committed Mar 14, 2022
1 parent 7e5ed84 commit 5616656
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
* Added modules ignored table to `nf-core modules bump-versions`. ([#1234](https://github.com/nf-core/tools/issues/1234))
* Added `--conda-package-version` flag for specifying version of conda package in `nf-core modules create`. ([#1238](https://github.com/nf-core/tools/issues/1238))
* Add option of writing diffs to file in `nf-core modules update` using either interactive prompts or the new `--diff-file` flag.
* Fixed edge case where module names that were substrings of other modules caused both to be installed ([#1380](https://github.com/nf-core/tools/issues/1380))

## [v2.2 - Lead Liger](https://github.com/nf-core/tools/releases/tag/2.2) - [2021-12-14]

Expand Down
2 changes: 1 addition & 1 deletion nf_core/modules/modules_repo.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def get_module_file_urls(self, module, commit=""):
"""
results = {}
for f in self.modules_file_tree:
if not f["path"].startswith("modules/{}".format(module)):
if not f["path"].startswith("modules/{}/".format(module)):
continue
if f["type"] != "blob":
continue
Expand Down

0 comments on commit 5616656

Please sign in to comment.