Close file before removing to satisfy Windows requirements - Linked: #27 #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As illustrated in #27, this PR adds the
os.close(...)
to handle closing files before attempting to remove them to satisfy Windows requirements. From local testing, this solves the observed issue, quite nicely.Changes:
os.close(...)
for both the temporary file and temporary SVG file.Linked Issues:
PermissionError ... cannot access the file because it is being used by another process:
on Windows #27Closing Thoughts: