Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding frontend initial flow with material ui. #7

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Conversation

6rivu
Copy link
Collaborator

@6rivu 6rivu commented Jan 25, 2022

Added home, mint-profile page, social graph page.

Copy link
Owner

@ewerx ewerx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no code comments. I don't know if you want design comments yet or we should save this for late, but the fonts and styling could use a pass.


require('react-dom');
window.React2 = require('react');
console.log(window.React1 === window.React2);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be included for the deploy?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, actually I included this for debugging the code incase two different versions of react is installed by mistake. I faced this issue while running the frontend on my local server. You can follow the issue here - facebook/react#2402

import { Button } from "@mui/material";

require('react-dom');
window.React2 = require('react');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you leave a comment explaining the need of doing this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking if two different versions of react have been installed for the app.js and the components. The same issue that I've linked to above.

import React from "react";
import { Grid } from "@mui/material";

require('react-dom');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why are you using cjs require as opposed to ES6 import?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just copy-pasted the debugging code from stackoverflow :p to solve the issue.

@6rivu 6rivu merged commit 4f3b420 into main Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants