Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict pyright #17

Merged
merged 4 commits into from
May 3, 2024
Merged

Strict pyright #17

merged 4 commits into from
May 3, 2024

Conversation

ewjoachim
Copy link
Owner

Closes #

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)

PR label(s):

souliane and others added 3 commits May 3, 2024 09:53
Keep pyright strict mode, but disable `reportUnknownMemberType` to
ignore the errors caused by `ruaml.yaml` methods that return `Any`.
@ewjoachim ewjoachim enabled auto-merge May 3, 2024 07:58
This was referenced May 3, 2024
@ewjoachim ewjoachim merged commit 7e56f1e into main May 3, 2024
7 checks passed
@ewjoachim ewjoachim deleted the strict-pyright branch May 3, 2024 08:16
Copy link
Contributor

github-actions bot commented May 3, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@souliane
Copy link
Contributor

souliane commented May 3, 2024

CI failed because I used the "new" notation to type with builtin dict instead of from typing import Dict. Sorry, I forgot to check that beforehand :-/

PS: using dict for type hints works from python 3.9

@ewjoachim
Copy link
Owner Author

Yeah I find it more readable to use quotes when we need (plus from __future__ import annotations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants