Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a "dylib" feature flag #6

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

InvalidString
Copy link
Contributor

It enables linking with raylib dynamically instead of statically.

Linking raylib dynamically allows you to hot reload game logic that uses it while keeping raylibs global state in tact.

I'm still learning about feature flags and pull requests on git, so I hope I did everything correctly.

@ewpratten
Copy link
Owner

Thank you for the PR! I'll be taking a look within the next hour or two. If there are any issues, I'll reach out here.

@ewpratten
Copy link
Owner

Enabling CI..

@ewpratten
Copy link
Owner

Ok, note to self. Currently the CI build job is running cargo with --all-features which will always build with dylib enabled. I'll need to write two jobs (one with, and one without) instead.

@ewpratten
Copy link
Owner

Awesome. CI is happy. Merging. Thanks again for the work!

@ewpratten ewpratten merged commit a496f2b into ewpratten:master Oct 16, 2023
2 checks passed
@ewpratten
Copy link
Owner

Build success, version 4.5.4 published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants