Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/fix hostname of us-gov-west-1. #1090

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

mmzx
Copy link
Contributor

@mmzx mmzx commented Oct 7, 2024

Issue, demonstrated via comparing against us-gov-east-1 which works as desired:
Screenshot 2024-10-07 at 14 47 03

Desire according to aws documentation:
image

This pull-request brings:
Screenshot 2024-10-07 at 14 56 44

@mmzx mmzx changed the title Fix hostname of us-gov-west-1. Add/fix hostname of us-gov-west-1. Oct 7, 2024
@pranay-kolhe
Copy link

pranay-kolhe commented Oct 8, 2024

@bernardd Tagging you as this MR is similar to the one where we requested extended regions support. Would it be possible to release a new version with 'us-gov-west-1' region support soon? I would greatly appreciate it.

@bernardd bernardd merged commit edd230a into ex-aws:main Oct 8, 2024
12 checks passed
@bernardd
Copy link
Contributor

bernardd commented Oct 8, 2024

Thanks @mmzx!

@mmzx
Copy link
Contributor Author

mmzx commented Oct 9, 2024

Thank you @bernardd and thank you for your efforts maintaining these sets of libraries!

@mmzx
Copy link
Contributor Author

mmzx commented Oct 9, 2024

@pranay-kolhe this is potentially a useful read.

@pranay-kolhe
Copy link

Thank you @bernardd for the support! I really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants