Make debug logging configurable #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the logger mode is not in debug mode, we should not be generating strings only to have them ignored. Using `inspect/1` is not free and we can be a little more memory efficient with this.
This forces the logger level to whatever the level is defined for `:ex_phone_number` on compilation, but this poisons the logger configuration downstream for other dependencies as they are compiled.
With debug log enabled ``` Compiling 22 files (.ex) 10:50:17.327 [debug] ----- Territory ----- 10:50:17.334 [debug] %ExPhoneNumber.Metadata.P ..... ``` With debug log disabled ``` Compiling 22 files (.ex) Generated ex_phone_number app ```
warmwaffles
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
Logger.configureis called during compilation to try and shut the logger up for normal use. Instead I lifted all of theLogger.debugcalls to a helperlog_debugfunction that effectively no-ops when not in debug mode.In
exqliteI use theV=1environment variable to spit out compilation debug info for make files. I don't know if this is something desired for the project, so I just stuck withDEBUGas the env var.With debug log enabled
With debug log disabled
You may also specify
debug_log: truein your configuration prior to compilation as well.And of course, at runtime you can force it to
trueand execute thePhoneMetadataparsing and it'll log the data out.