✨ Risk feed #1197
Merged
✨ Risk feed #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sebipap
reviewed
Sep 8, 2023
Comment on lines
+8
to
+11
| useEffect(() => { | ||
| funcRef.current = fn; | ||
| }, [fn]); |
There was a problem hiding this comment.
Every time fn changes, the value of funcRef.current also changes because of the useEffect. So funcRef.current always reflects the most recent value of fn. I believe you could use fn directly instead of maintaining and updating a separate reference.
There was a problem hiding this comment.
Yes, but that would trigger the effect, on every fn change (even if it's the same func defined inline), this is just a minor thing to avoid having to wrap the call with useCallback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1192
/activity. There is no link in the app to it stillPreview of page