Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Revoke Allowances #1198

Closed
wants to merge 1 commit into from
Closed

✨Revoke Allowances #1198

wants to merge 1 commit into from

Conversation

sebipap
Copy link
Contributor

@sebipap sebipap commented Sep 6, 2023

closes #1193

Manage allowances for

  • DebtManager => (USDC, OP, WETH, ...)
  • DebtManager => market shares (exaUSDC, exaOP ...)
  • Markets => USDC, OP, WETH, ...
  • MarketETHRouter => exaWETH

Note for testing

  • Manage allowances in the wallet address menu in the top-right of the screen
image

@vercel
Copy link

vercel bot commented Sep 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2023 2:27pm

@sebipap sebipap temporarily deployed to Preview September 6, 2023 18:48 — with GitHub Actions Inactive
jgalat
jgalat previously approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@jgalat jgalat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! great work, just a minor comment

components/Allowances/index.tsx Outdated Show resolved Hide resolved
@sebipap sebipap temporarily deployed to Preview September 7, 2023 13:34 — with GitHub Actions Inactive
@sebipap sebipap temporarily deployed to Preview September 7, 2023 13:36 — with GitHub Actions Inactive
jgalat
jgalat previously approved these changes Sep 7, 2023
View reviewed changes
@JuampiRombola
Copy link
Contributor

image image

Nice work Seba! Just a few comments regarding the UI:

  1. The menu width should be smaller
  2. The button icons should be smaller
  3. The copy button should be bigger
  4. The divider line is missing

@sebipap sebipap temporarily deployed to Preview September 7, 2023 17:45 — with GitHub Actions Inactive
@sebipap sebipap temporarily deployed to Preview September 7, 2023 18:20 — with GitHub Actions Inactive
@sebipap sebipap temporarily deployed to Preview September 7, 2023 18:48 — with GitHub Actions Inactive
@sebipap
Copy link
Contributor Author

sebipap commented Sep 7, 2023 •
edited
Loading

Nice work Seba! Just a few comments regarding the UI:

  1. The menu width should be smaller✅
  2. The button icons should be smaller✅
  3. The copy button should be bigger✅
  4. The divider line is missing✅

thanks for the feedback juampi!

JuampiRombola
JuampiRombola previously approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@JuampiRombola JuampiRombola left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Just a minor comment, when the wallet is not connected, the revoke page keeps loading forever

components/Allowances/AllowancesMobile.tsx Outdated Show resolved Hide resolved
hooks/useAllowances.ts Outdated Show resolved Hide resolved
components/Allowances/index.tsx Show resolved Hide resolved
pages/revoke.tsx Show resolved Hide resolved
@JuampiRombola
Copy link
Contributor

Another comment (if you consider it is in the scope of your task), could you reduce the gap between the menu and the navbar?
image
image

@sebipap sebipap temporarily deployed to Preview September 7, 2023 19:42 — with GitHub Actions Inactive
@sebipap
Copy link
Contributor Author

sebipap commented Sep 7, 2023 •
edited
Loading

Another comment (if you consider it is in the scope of your task), could you reduce the gap between the menu and the navbar?

fixed!

@sebipap sebipap temporarily deployed to Preview September 7, 2023 20:01 — with GitHub Actions Inactive
@sebipap sebipap temporarily deployed to Preview September 7, 2023 20:09 — with GitHub Actions Inactive
JuampiRombola
JuampiRombola previously approved these changes Sep 7, 2023
View reviewed changes
@sebipap sebipap temporarily deployed to Preview September 8, 2023 19:53 — with GitHub Actions Inactive
@sebipap
✨Revoke Allowances
62f7eef 
manage allowances to Exactly contracts
@sebipap sebipap temporarily deployed to Preview September 11, 2023 14:22 — with GitHub Actions Inactive
@jgalat
Copy link
Contributor

jgalat commented Sep 11, 2023

This is getting merged as part of #1201

@jgalat jgalat closed this Sep 11, 2023
@jgalat jgalat deleted the revoke branch September 12, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuampiRombola JuampiRombola JuampiRombola left review comments

@jgalat jgalat jgalat left review comments

@cruzdanilo cruzdanilo Awaiting requested review from cruzdanilo

@franm91 franm91 Awaiting requested review from franm91

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allowance information + revoke/change input and button
3 participants
@sebipap @JuampiRombola @jgalat