Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ E2E: Introduce Playwright #1204

Merged
merged 9 commits into from
Sep 19, 2023
Merged

✨ E2E: Introduce Playwright #1204

merged 9 commits into from
Sep 19, 2023

Conversation

jgalat
Copy link
Contributor

@jgalat jgalat commented Sep 14, 2023

closes #1196

This introduces Playwright as engine to run our E2E suite (replacing Cypress)

These are the times using 4 shards. Each shard ran 2 to 3 tests.
Cache missed here.
image
image

With cache hit here (+ check)
image

  • Framework setup (& Cypress removal)
  • Test migration
  • Add GitHub action
  • Update README

@vercel
Copy link

vercel bot commented Sep 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 8:12pm

@jgalat jgalat requested a review from cruzdanilo as a code owner September 15, 2023 18:49
@jgalat jgalat temporarily deployed to Test September 15, 2023 18:56 — with GitHub Actions Inactive
@jgalat jgalat temporarily deployed to Test September 15, 2023 18:56 — with GitHub Actions Inactive
@jgalat jgalat temporarily deployed to Test September 15, 2023 18:56 — with GitHub Actions Inactive
@jgalat jgalat temporarily deployed to Test September 15, 2023 18:56 — with GitHub Actions Inactive
sebipap
sebipap previously approved these changes Sep 15, 2023
Copy link
Contributor

@sebipap sebipap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!
comments are dismissable

e2e/components/wallet.ts Outdated Show resolved Hide resolved
utils/client.ts Outdated Show resolved Hide resolved
@jgalat jgalat temporarily deployed to Test September 15, 2023 20:15 — with GitHub Actions Inactive
@jgalat jgalat temporarily deployed to Test September 15, 2023 20:15 — with GitHub Actions Inactive
@jgalat jgalat temporarily deployed to Test September 15, 2023 20:15 — with GitHub Actions Inactive
@jgalat jgalat temporarily deployed to Test September 15, 2023 20:15 — with GitHub Actions Inactive
Copy link
Member

@cruzdanilo cruzdanilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cruzdanilo cruzdanilo merged commit 19e2d2f into main Sep 19, 2023
7 checks passed
@cruzdanilo cruzdanilo deleted the e2e branch September 19, 2023 12:09
@cruzdanilo cruzdanilo temporarily deployed to Production September 19, 2023 12:09 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E completeness
5 participants