Skip to content

Commit

Permalink
chore: fix linting issues from 4th version updates
Browse files Browse the repository at this point in the history
  • Loading branch information
ala-n committed Jul 15, 2024
1 parent a41d91f commit 2eef9a2
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 8 deletions.
3 changes: 2 additions & 1 deletion site/src/esl-popup/esl-d-popup-game.less
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ esl-d-popup-game {
height: 95%;
width: 100%;

&::before, &::after {
&::before,
&::after {
position: absolute;
font-size: calc(min(100vh, 300px) / 3);
display: inline-block;
Expand Down
8 changes: 4 additions & 4 deletions src/modules/esl-carousel/core/esl-carousel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,22 +65,22 @@ export class ESLCarousel extends ESLBaseElement {
/** Renderer type {@link ESLMediaRuleList} instance */
@memoize()
public get typeRule(): ESLMediaRuleList<string> {
return ESLMediaRuleList.parse(this.media, this.type);
return ESLMediaRuleList.parseTuple(this.media, this.type);
}
/** Loop marker {@link ESLMediaRuleList} instance */
@memoize()
public get loopRule(): ESLMediaRuleList<boolean> {
return ESLMediaRuleList.parse(this.media, this.loop, parseBoolean);
return ESLMediaRuleList.parseTuple(this.media, this.loop, parseBoolean);
}
/** Count of visible slides {@link ESLMediaRuleList} instance */
@memoize()
public get countRule(): ESLMediaRuleList<number> {
return ESLMediaRuleList.parse(this.media, this.count, parseInt);
return ESLMediaRuleList.parseTuple(this.media, this.count, parseInt);
}
/** Orientation of the carousel {@link ESLMediaRuleList} instance */
@memoize()
public get verticalRule(): ESLMediaRuleList<boolean> {
return ESLMediaRuleList.parse(this.media, this.vertical, parseBoolean);
return ESLMediaRuleList.parseTuple(this.media, this.vertical, parseBoolean);
}

/** Returns observed media rules */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class ESLCarouselTouchMixin extends ESLCarouselPlugin {
/** @returns rule {@link ESLMediaRuleList} for touch types */
@memoize()
public get typeRule(): ESLMediaRuleList<TouchType> {
return ESLMediaRuleList.parse(this.type || ESLCarouselTouchMixin.DRAG_TYPE, toTouchType);
return ESLMediaRuleList.parseQuery(this.type || ESLCarouselTouchMixin.DRAG_TYPE, toTouchType);
}

/** @returns whether the swipe mode is active */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,12 @@
transition: transform 0.25s linear;
}

/* stylelint-disable-next-line */
&.esl-carousel-horizontal :is([esl-carousel-slide], [esl-carousel-fake-slide]) {
width: var(--esl-slide-size);
}

/* stylelint-disable-next-line */
&.esl-carousel-vertical :is([esl-carousel-slide], [esl-carousel-fake-slide]) {
height: var(--esl-slide-size);
}
Expand Down
6 changes: 4 additions & 2 deletions src/modules/esl-media/core/esl-media.less
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,14 @@
}
}

&:not([wide])[fill-mode='cover'] .esl-media-inner, &[wide][fill-mode='inscribe'] .esl-media-inner {
&:not([wide])[fill-mode='cover'] .esl-media-inner,
&[wide][fill-mode='inscribe'] .esl-media-inner {
width: auto;
height: 100%;
}

&:not([wide])[fill-mode='inscribe'] .esl-media-inner, &[wide][fill-mode='cover'] .esl-media-inner {
&:not([wide])[fill-mode='inscribe'] .esl-media-inner,
&[wide][fill-mode='cover'] .esl-media-inner {
width: 100%;
height: auto;
}
Expand Down

0 comments on commit 2eef9a2

Please sign in to comment.