Skip to content

Commit

Permalink
fix(esl-event-listener): fix missing signature for $$on method of b…
Browse files Browse the repository at this point in the history
…ase component
  • Loading branch information
ala-n committed Jul 3, 2024
1 parent 0a5fe2b commit 7197e30
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/modules/esl-base-element/core/esl-base-element.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ export abstract class ESLBaseElement extends HTMLElement implements ESLBaseCompo
return this._connected;
}

/** Subscribes (or resubscribes) all known descriptors that matches criteria */
public $$on(criteria: ESLListenerCriteria): ESLEventListener[];
/** Subscribes `handler` method marked with `@listen` decorator */
public $$on(handler: ESLListenerHandler): ESLEventListener[];
/** Subscribes `handler` function by the passed DOM event descriptor {@link ESLListenerDescriptor} or event name */
Expand Down
2 changes: 2 additions & 0 deletions src/modules/esl-mixin-element/ui/esl-mixin-element.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ export class ESLMixinElement implements ESLBaseComponent, ESLDomElementRelated {
*/
protected attributeChangedCallback(name: string, oldValue: string | null, newValue: string | null): void {}

/** Subscribes (or resubscribes) all known descriptors that matches criteria */
public $$on(criteria: ESLListenerCriteria): ESLEventListener[];
/** Subscribes `handler` method marked with `@listen` decorator */
public $$on(handler: ESLListenerHandler): ESLEventListener[];
/** Subscribes `handler` function by the passed DOM event descriptor {@link ESLListenerDescriptor} or event name */
Expand Down
2 changes: 2 additions & 0 deletions src/modules/esl-utils/abstract/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import type {
} from '../../esl-event-listener/core';

export interface ESLBaseComponent {
/** Subscribes (or resubscribes) all known descriptors that matches criteria */
$$on(criteria: ESLListenerCriteria): ESLEventListener[];
/** Subscribes `handler` method marked with `@listen` decorator */
$$on(handler: ESLListenerHandler): ESLEventListener[];
/** Subscribes `handler` function by the passed DOM event descriptor {@link ESLListenerDescriptor} or event name */
Expand Down

0 comments on commit 7197e30

Please sign in to comment.