chore(esl-media-query): drop ESLMediaRuleList.parse lint rule

exadel-inc · Jul 17, 2024 · bd764b2 · bd764b2
1 parent add038a
commit bd764b2
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 7 deletions.
diff --git a/eslint/src/rules/4/all.rules.ts b/eslint/src/rules/4/all.rules.ts
@@ -6,16 +6,13 @@ import deprecatedToggleableActionParams from './deprecated.toggleable-action-par
 
 import deprecatedBaseDecoratorsPath from './deprecated.base-decorators-path';
 
-import deprecatedMediaRuleListParse from './deprecated.media-rule-list-parse';
-
 export default {
   // Aliases
   'deprecated-4/generate-uid': deprecatedGenerateUid,
   'deprecated-4/deep-compare': deprecatedDeepCompare,
   'deprecated-4/event-utils': deprecatedEventUtils,
   'deprecated-4/traversing-query': deprecatedTraversingQuery,
   'deprecated-4/toggleable-action-params': deprecatedToggleableActionParams,
-  'deprecated-4/media-rule-list-parse': deprecatedMediaRuleListParse,
   // Paths
   'deprecated-4/base-decorators-path': deprecatedBaseDecoratorsPath
 };
diff --git a/eslint/src/rules/4/deprecated.media-rule-list-parse.ts b/eslint/src/rules/4/deprecated.media-rule-list-parse.ts
@@ -8,12 +8,11 @@ import type {ESLintReplacementMethodCfg} from '../../core/deprecated-class-metho
 
 const AVAILABLE_SINCE = '5.0.0-beta.24';
 const isActual = lte(ESL_PACKAGE_VERSION, AVAILABLE_SINCE);
-const isTest = process.env.NODE_ENV === 'test';
 
 /**
  * Rule for deprecated 'parse' method of {@link ESLMediaRuleList}
  */
-export default isActual || isTest ?
+export default isActual ?
   buildRule({
     className: 'ESLMediaRuleList',
     deprecatedMethod: 'parse',

diff --git a/eslint/test/deprecated-class-method.test.ts b/eslint/test/deprecated-class-method.test.ts
@@ -1,7 +1,7 @@
 import {RuleTester} from 'eslint';
 import {buildRule} from '../src/core/deprecated-class-method';
 
-import deprecatedMediaRuleListParse from '../src/rules/4/deprecated.media-rule-list-parse';
+import type * as ESTree from 'estree';
 
 const VALID_CASES = [
   {
@@ -189,7 +189,18 @@ describe('ESL Migration Rules: Deprecated Static Method: valid', () => {
 });
 
 describe('ESL Migration Rules: Deprecated Static Method: valid', () => {
-  const rule = deprecatedMediaRuleListParse;
+  const rule = buildRule({
+    className: 'ESLMediaRuleList',
+    deprecatedMethod: 'parse',
+    getReplacementMethod: (expression) => {
+      const args = expression.arguments;
+      const isLiteral = (node: ESTree.Expression | ESTree.SpreadElement): boolean => node?.type === 'Literal' || node?.type === 'TemplateLiteral';
+      if (expression.type === 'CallExpression' && args.length === 1) return 'parseQuery';
+      if (expression.type === 'CallExpression' && args.length === 2 && isLiteral(args[1])) return 'parseTuple';
+      if (expression.type === 'CallExpression' && args.length === 3) return 'parseTuple';
+      return {message: 'ESLMediaRuleList.parseQuery or ESLMediaRuleList.parseTuple'};
+    }
+  });
 
   const ruleTester = new RuleTester({
     parser: require.resolve('@typescript-eslint/parser')