Skip to content

Commit

Permalink
fix(esl-carousel): improve log messaging and fix initialization excep…
Browse files Browse the repository at this point in the history
…tions
  • Loading branch information
ala-n committed Jul 1, 2024
1 parent 37f01bd commit cfd930c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/modules/esl-carousel/core/esl-carousel.slide.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ export class ESLCarouselSlide extends ESLMixinElement {

@ready
protected override connectedCallback(): void {
if (!this.$carousel) return;
this.$carousel?.addSlide && this.$carousel.addSlide(this.$host);
super.connectedCallback();
this.updateA11y();
Expand Down
2 changes: 1 addition & 1 deletion src/modules/esl-carousel/plugin/esl-carousel.plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export abstract class ESLCarouselPlugin extends ESLMixinElement {
return true;
} else {
const {is} = this.constructor as typeof ESLCarouselPlugin;
console.error('[ESL]: %o is not correct target for %o', $host, is);
console.debug('[ESL]: ESLCarousel plugin %s rejected for non correct target %o', is, $host);
this.$host.removeAttribute(is);
return false;
}
Expand Down

0 comments on commit cfd930c

Please sign in to comment.