Merge pull request #2538 from exadel-inc/fix/count-reserve-slides

fix(esl-carousel): fix count of slides to be rendered before the first slide
exadel-inc · Jul 25, 2024 · daea2a9 · daea2a9
2 parents 4bc8b55 + cd68ea3
commit daea2a9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/modules/esl-carousel/renderers/esl-carousel.default.renderer.ts b/src/modules/esl-carousel/renderers/esl-carousel.default.renderer.ts
@@ -175,15 +175,15 @@ export class ESLDefaultCarouselRenderer extends ESLCarouselRenderer {
   /**
    * @returns count of slides to be rendered (reserved) before the first slide
    */
-  protected calcReserveCount(back?: boolean): number {
+  protected getReserveCount(back?: boolean): number {
     const {size, count, loop, currentIndex} = this;
     const freeSlides = size - count;
     // no need to reorder if there are no free slides or loop is disabled
     if (!loop || !freeSlides) return 0;
     // if back option is not set, prefer to reserve slides with respect to semantic order
     if (typeof back !== 'boolean') back = !!currentIndex;
     // otherwise, ensure that there are at least half of free slides reserved (if the back option is set - round up, otherwise - round down)
-    return Math.min(count, back ? Math.ceil(freeSlides / 2) : Math.floor(freeSlides / 2));
+    return back ? Math.ceil(freeSlides / 2) : Math.floor(freeSlides / 2);
   }
 
   /**
@@ -192,7 +192,7 @@ export class ESLDefaultCarouselRenderer extends ESLCarouselRenderer {
    */
   protected reorder(back?: boolean): void {
     const {size, loop, currentIndex, $slides} = this;
-    const reserve = this.calcReserveCount(back);
+    const reserve = this.getReserveCount(back);
 
     const index = loop ? currentIndex : 0;
     for (let i = 0; i < size; ++i) {

diff --git a/src/modules/esl-carousel/renderers/esl-carousel.grid.renderer.ts b/src/modules/esl-carousel/renderers/esl-carousel.grid.renderer.ts
@@ -96,8 +96,8 @@ export class ESLGridCarouselRenderer extends ESLDefaultCarouselRenderer {
   /**
    * @returns count of slides to be rendered (reserved) before the first slide does not include fake slides
    */
-  protected override calcReserveCount(back?: boolean): number {
-    const reserve = super.calcReserveCount(back);
+  protected override getReserveCount(back?: boolean): number {
+    const reserve = super.getReserveCount(back);
     return reserve - (reserve % this.ROWS);
   }