ESL Popup position: tests and refactoring #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshovchko
requested review from
ala-n,
julia-murashko,
yadamskaya,
abarmina,
Natalie-Smirnova,
fshovchko,
HenadzV and
NastaLeo
yadamskaya
approved these changes
Feb 22, 2024
src/modules/esl-popup/test/esl-popup-position.behaviour-fit-minor.test.ts
Outdated
Show resolved
Hide resolved
src/modules/esl-popup/test/esl-popup-position.behaviour-fit-minor.test.ts
Outdated
Show resolved
Hide resolved
NastaLeo
approved these changes
Feb 22, 2024
ala-n
approved these changes
Feb 23, 2024
fshovchko
reviewed
Feb 26, 2024
src/modules/esl-popup/test/esl-popup-position.behaviour-fit-minor.test.ts
Outdated
Show resolved
Hide resolved
fshovchko
approved these changes
Feb 26, 2024
abarmina
approved these changes
Feb 27, 2024
|
🎉 This PR is included in version 5.0.0-beta.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.