chore(site): rework esl-popup game demo page using ui playground
#2357
Conversation
fshovchko
added
enhancement
fshovchko
requested review from
dshovchko,
ala-n and
julia-murashko
and removed request for
a team
There was a problem hiding this comment.
Works better but still not ideal.
Scenario 1: garb and move the "rocket" fast to the separate corner, but keep cursor inside the area.
Current result: the "rocket" and cursor shifted from each other
Expected result: the cursor does not change its position relatively to "rocket" until bounds are reached.
Suggestion: Please note that the delta approach is not stable for such cases in general. It's better to translate the total pointer movement to our coordinate system. Please look at the carousel touch plugin or scrollbar for reference.
Scenario 2:
The suggestion bellow, regarding RAF decoration makes things a little bit more unstable even if the popup is not opened.
Expected result: it should be super smooth, the user can have tens of popups and hundreds of triggest, and we should not have any performance issues on one trigger with a closed popup (It could be a popup issue but it looks like it's only demo problem, popup feels itself super fine from consumers side with beta release at that moment)
|
Let's discuss on the nearest ESL meeting |
ala-n
added
needs review
Co-authored-by: ala'n (Alexey Stsefanovich) <astsefanovich@exadel.com>
Co-authored-by: Dmytro Shovchko <d.shovchko@gmail.com>
…re/rework-popup-game # Conflicts: # site/src/localdev.less
|
🎉 This PR is included in version 5.0.0-beta.23 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes: #2345