feat(esl-carousel): rework carousel plugins API to use json attr + smart media query #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ala-n
requested review from
a team,
yadamskaya,
abarmina and
fshovchko
and removed request for
a team
ala-n
added
enhancement
… => value` (query case)
NastaLeo
reviewed
Jul 22, 2024
NastaLeo
approved these changes
Jul 22, 2024
yadamskaya
reviewed
Jul 22, 2024
Co-authored-by: alesun <alesun@exadel.com>
abarmina
approved these changes
Jul 22, 2024
yadamskaya
approved these changes
Jul 22, 2024
fshovchko
reviewed
Jul 22, 2024
fshovchko
approved these changes
Jul 22, 2024
…t/carousel-rework-3
dshovchko
approved these changes
Jul 22, 2024
|
|
||
| import {ESLCarouselPlugin} from '../esl-carousel.plugin'; | ||
| import {ESLCarouselSlideEvent} from '../../core/esl-carousel.events'; | ||
|
|
||
| export interface ESLCarouselAutoplayConfig { | ||
| /** Timeout to send next command to the host carousel */ |
There was a problem hiding this comment.
Is it really timeout? Or delay?
There was a problem hiding this comment.
It sounds like we need to discuss variable name as well.
I'll add a note to the cleanup ticket. Let's revisit it separately
|
🎉 This issue has been resolved in version 5.0.0-beta.25 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.