-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(esl-carousel): rework carousel plugins API to use json attr + smart media query #2524
Conversation
… => value` (query case)
Co-authored-by: alesun <alesun@exadel.com>
…t/carousel-rework-3
|
||
import {ESLCarouselPlugin} from '../esl-carousel.plugin'; | ||
import {ESLCarouselSlideEvent} from '../../core/esl-carousel.events'; | ||
|
||
export interface ESLCarouselAutoplayConfig { | ||
/** Timeout to send next command to the host carousel */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really timeout? Or delay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds like we need to discuss variable name as well.
I'll add a note to the cleanup ticket. Let's revisit it separately
🎉 This issue has been resolved in version 5.0.0-beta.25 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.