-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(esl-carousel): rework default renderer animation approach (now uses js animation) #2555
Conversation
…ses js animation)
await this.$area.animate({ | ||
transform: [`translate3d(${this.vertical ? `0px, ${offset}px` : `${offset}px, 0px`}, 0px)`] | ||
}, {duration: 250, easing: 'linear'}).finished; | ||
this.$carousel.$$attr('animating', false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just cosmetic to define a method something like setAnimationState()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But what will be the purpose? it is not public and is commonly used for other methods or inheritors. From the current update state animateTransformOffset
and only animateTransformOffset
should process animation and notify regarding the animation state. It is not designed for animated markers to be updated out of the context of animation
fix(esl-carousel): direction related issues, cleanup internal nav API (rename dir to direction)
🎉 This issue has been resolved in version 5.0.0-beta.31 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.