Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add intersection, union, complement, fullIntersection, array utility methods #455

Merged
merged 7 commits into from
Sep 10, 2021
Merged

feat: add intersection, union, complement, fullIntersection, array utility methods #455

merged 7 commits into from
Sep 10, 2021

Conversation

Anna-MariiaPetryk
Copy link
Collaborator

@Anna-MariiaPetryk Anna-MariiaPetryk commented Sep 6, 2021 •
edited by ala-n
Loading

  • add new utilities to the set group due to the uniqueness requirement/result for added utilities

@Anna-MariiaPetryk Anna-MariiaPetryk added the feature New feature label Sep 6, 2021
@Anna-MariiaPetryk Anna-MariiaPetryk requested review from a team September 6, 2021 07:53
@Anna-MariiaPetryk Anna-MariiaPetryk self-assigned this Sep 6, 2021
@Anna-MariiaPetryk Anna-MariiaPetryk requested review from dshovchko, ala-n and julia-murashko and removed request for a team September 6, 2021 07:53
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️

ala-n
ala-n requested changes Sep 6, 2021
View reviewed changes
Copy link
Collaborator

@ala-n ala-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to request updates:

  • please see mentioned requirements in the comment
  • update test set acordingly

src/modules/esl-utils/misc/array.ts Outdated Show resolved Hide resolved
src/modules/esl-utils/misc/array.ts Outdated Show resolved Hide resolved
src/modules/esl-utils/misc/array.ts Outdated Show resolved Hide resolved
src/modules/esl-utils/misc/array.ts Outdated Show resolved Hide resolved
src/modules/esl-utils/misc/array.ts Outdated Show resolved Hide resolved
ala-n
ala-n requested changes Sep 7, 2021
View reviewed changes
src/modules/esl-utils/misc/array.ts Outdated Show resolved Hide resolved
src/modules/esl-utils/misc/array.ts Outdated Show resolved Hide resolved
src/modules/esl-utils/misc/array.ts Outdated Show resolved Hide resolved
src/modules/esl-utils/misc/array.ts Outdated Show resolved Hide resolved
src/modules/esl-utils/misc/test/array.test.ts Outdated Show resolved Hide resolved
@Anna-MariiaPetryk Anna-MariiaPetryk marked this pull request as ready for review September 7, 2021 16:30
@ala-n ala-n requested review from abarmina and yadamskaya September 9, 2021 13:40
@ala-n ala-n changed the title feat: add intersection, union, complement, fullIntersection, array u… feat: add intersection, union, complement, fullIntersection, array utility methods Sep 9, 2021
@ala-n ala-n changed the base branch from main-beta to main September 9, 2021 13:51
@ala-n ala-n changed the base branch from main to main-beta September 9, 2021 14:22
@ala-n ala-n changed the base branch from main-beta to main September 9, 2021 14:24
@ala-n ala-n merged commit 0ac4de0 into main Sep 10, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2021
@ala-n ala-n deleted the add-array-utils branch September 16, 2021 01:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abarmina abarmina abarmina approved these changes

@yadamskaya yadamskaya yadamskaya approved these changes

@julia-murashko julia-murashko julia-murashko approved these changes

@ala-n ala-n ala-n approved these changes

@dshovchko dshovchko Awaiting requested review from dshovchko

Assignees

@Anna-MariiaPetryk Anna-MariiaPetryk

Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Anna-MariiaPetryk @ala-n @julia-murashko @yadamskaya @abarmina