Feature/replace ace editor #512
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ |
…to feature/replace-ace-editor
src/plugins/editor/editor.less
Outdated
| transition: max-height 0.3s ease-in-out; | ||
|
|
||
| &-inner { | ||
| height: 100%; | ||
| border-top: 1px solid @section-border; | ||
| } | ||
|
|
||
| .uip-root.dark-theme & { | ||
| @import "./jar/dark-theme.less"; |
There was a problem hiding this comment.
I guess we can name this file jar-editor.less, leave only basic styles, import this file here above, and add needed styles for jar editor in case dark theme
Make sence?
src/plugins/editor/jar/jar-editor.ts
Outdated
| /** Handle editor's content change */ | ||
| @bind | ||
| private _onChange() { | ||
| this.dispatchEvent(new CustomEvent('editor-change')); |
There was a problem hiding this comment.
I'd better add prefix uip to event name as we do for all our events and maybe change it a little bit. As a reference, how every setting send change event to the main settings component: uip:change
Or if we consider these changes as a third- party library change mybe we shoul leave it without prefix....
|
🎉 This PR is included in version 1.1.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.