feat(core): plugin defaults #794
Open
+94
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fshovchko
requested review from
dshovchko,
ala-n,
yadamskaya,
abarmina and
NastaLeo
ala-n
reviewed
Jul 25, 2024
There was a problem hiding this comment.
This upadate does not introduce any defaults, so it does not close the related issue.
That PR just giving ground to do defaults trough @attr functionality by replacing @boolAttr.
Please update PR description or extend the solution with the requirements mentioned in the ticket.
|
It needs to be tested on the customer side first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #627