Refactoring/#221 fixed mypy warnings #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some still need to be clarified
in RegisterPeerForwarder RegisterPeerForwarderBuilderParameter RegisterPeerForwarderFactory
ckunki
commented
Nov 25, 2024
exasol/analytics/udf/communication/peer_communicator/background_listener_thread.py
Outdated
Show resolved
Hide resolved
ckunki
commented
Nov 25, 2024
exasol/analytics/query_handler/graph/stage/sql/execution/query_handler_state.py
Show resolved
Hide resolved
ckunki
commented
Nov 25, 2024
ckunki
commented
Nov 25, 2024
ckunki
commented
Nov 25, 2024
tkilias
reviewed
Nov 25, 2024
exasol/analytics/query_handler/context/proxy/bucketfs_location_proxy.py
Outdated
Show resolved
Hide resolved
tkilias
reviewed
Nov 25, 2024
tkilias
reviewed
Nov 25, 2024
tkilias
reviewed
Nov 25, 2024
tkilias
reviewed
Nov 25, 2024
tkilias
reviewed
Nov 25, 2024
tkilias
reviewed
Nov 25, 2024
tkilias
reviewed
Nov 25, 2024
3 tasks
tomuben
reviewed
Nov 27, 2024
exasol/analytics/udf/communication/peer_communicator/background_listener_interface.py
Show resolved
Hide resolved
tomuben
reviewed
Nov 27, 2024
exasol/analytics/udf/communication/peer_communicator/background_listener_thread.py
Show resolved
Hide resolved
tomuben
reviewed
Nov 27, 2024
exasol/analytics/udf/communication/socket_factory/fault_injection.py
Outdated
Show resolved
Hide resolved
tomuben
reviewed
Nov 27, 2024
exasol/analytics/udf/communication/socket_factory/zmq_wrapper.py
Outdated
Show resolved
Hide resolved
tomuben
reviewed
Nov 27, 2024
tomuben
reviewed
Nov 27, 2024
tomuben
reviewed
Nov 27, 2024
tomuben
reviewed
Nov 27, 2024
tomuben
requested changes
Nov 27, 2024
Co-authored-by: Thomas Ubensee <34603111+tomuben@users.noreply.github.com>
I assume the type checker was activated all the time in checks.yml: but mypy was told to ignore all package of the project in pyproject.toml. The latter I updated. |
tomuben
previously approved these changes
Nov 28, 2024
tkilias
approved these changes
Dec 2, 2024
tkilias
reviewed
Dec 2, 2024
| pandas = "^1.1.0" | ||
| # request from Mikhail: | ||
| # pandas = "^2.2.3" | ||
| pandas = "^2.2.3" | ||
| pydantic = "^1.10.2" |
There was a problem hiding this comment.
We should upgrade pydantic to version 2 it might otherwise conflict with other projects
There was a problem hiding this comment.
See ticket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #221
Closes #222
Closes #223
Closes #229