Added some comments and docstrings #242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckunki
reviewed
Dec 20, 2024
| @@ -13,6 +13,9 @@ class Dataset: | |||
|
|
|||
| The TableLike refers to a database table containing the actual data that | |||
| can be used for instance in training or testing. | |||
|
|
|||
| Q. A TableLike is basically a list of columns and a name. Why do we have | |||
| a separate list of columns here? | |||
There was a problem hiding this comment.
AFAIK there was and is a separation of "ordinary" columns and "identifier columns" which may be handled specially in some cases? But the attribute columns could be superfluous in my understanding.
ckunki
reviewed
Dec 20, 2024
ckunki
requested changes
Dec 20, 2024
| """ | ||
| This is a node of an ExecutionGraph. | ||
| Essentially, this is a node-level query handler factory. The query handler | ||
| itself is user-provided and so is this factory. |
There was a problem hiding this comment.
Suggested change
| itself is user-provided and so is this factory. | |
| itself is user-provided and so are the factories implementing this interface. |
Comment on lines
+11
to
+13
| This is a type root for a class representing an input/output data for a customer | ||
| provided node-level query handler - SQLStageQueryHandler. The actual content of | ||
| the input/output is application specific. |
There was a problem hiding this comment.
Suggested change
| This is a type root for a class representing an input/output data for a customer | |
| provided node-level query handler - SQLStageQueryHandler. The actual content of | |
| the input/output is application specific. | |
| This is a type root for a class representing input/output data for a customer | |
| provided node-level query handler extending class SQLStageQueryHandler. The actual content of | |
| the input/output is application-specific. |
| @@ -98,6 +105,11 @@ def handle_result( | |||
| def _handle_finished_result( | |||
| self, result: Finish[SQLStageInputOutput] | |||
| ) -> ResultHandlerReturnValue: | |||
| """ | |||
| We are done with the current node. | |||
| If there are successors we need to add the final output from this node to the | |||
There was a problem hiding this comment.
Suggested change
| If there are successors we need to add the final output from this node to the | |
| If there are successors, then we need to add the final output from this node to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.