Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix javadoc generation #117

Closed
pj-spoelders opened this issue Jan 23, 2024 · 1 comment · Fixed by #116
Closed

Fix javadoc generation #117

pj-spoelders opened this issue Jan 23, 2024 · 1 comment · Fixed by #116
Assignees
Labels
refactoring Code improvement without behavior change

Comments

@pj-spoelders
Copy link
Contributor

pj-spoelders commented Jan 23, 2024

Currently javadoc is configured to not throw errors when failing in the current PR.

The javadoc plugin in this project had custom configuration (found in pom.xml file):
Javadoc fought with the udf-debugging-java dependency when I added it, this dependency is needed to add support for remote debugging the VS integration tests. That's why I had to disable javadoc for now.

@pj-spoelders pj-spoelders added the refactoring Code improvement without behavior change label Jan 23, 2024
@pj-spoelders
Copy link
Contributor Author

pj-spoelders added a commit that referenced this issue Mar 28, 2024
@pj-spoelders pj-spoelders self-assigned this Mar 28, 2024
pj-spoelders added a commit that referenced this issue Apr 2, 2024
…ues (#116)

* - added CI matrix for Exasol 7 and 8
- updated dependencies
- changed default DB version used to run CI tests
- ran PK and artifact unifier tool

* altered tests after changed vsjdbc 12.0.0 behaviour

* fix wildcard test using describe (zonemapping is a new column)

* fix grammatical error

* add support for remote debugging via udf-debugging-java

* ran pk fix after updating dependencies

* disable fail on error for javadoc for now

* fix tests

* update dependencies

* fix deprecated method warnings

* ran pk fix

* fix return type for timestamp with local date time
according to strict data type checking

* split and fix failing integration tests for exa connection mode, related to  strict datatype checks in the compiler

* Add update to PK 4.2.0 exclusion

* Use cast instead of localtimestamp for correct result

* fix testVisitSqlLiteralTimestampUtc test

* Add special cases for Exasol VS Local modus: explicit cast to utf8 in the case of char and varchar datatypes

* removed separate V8 tests I created cause, in hindsight, they serve little to no purpose, the assumeV7 indicator is enough.

* Update documentation

* #117 - fix javadoc generation

* Add missing javadoc comment

* Updated doc

* Apply suggestions from code review

Co-authored-by: Christoph Pirkl <4711730+kaklakariada@users.noreply.github.com>

* Update exasol.md

Improved documentation on data type mismatches.

* Update project keeper and workflow files + gitattributes file

* refactored localsqlgenerationvisitor

* removed throws statement

* unit tests for local sqlgeneration visitor

* fix code smell

* small refactoring, added final

* removed unused line

---------

Co-authored-by: Christoph Pirkl <4711730+kaklakariada@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
1 participant