Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-activate flaky Metabase test #21

Closed
kaklakariada opened this issue Jan 17, 2022 · 0 comments · Fixed by #33
Closed

Re-activate flaky Metabase test #21

kaklakariada opened this issue Jan 17, 2022 · 0 comments · Fixed by #33
Assignees
Labels
bug Something isn't working

Comments

@kaklakariada
Copy link
Collaborator

kaklakariada commented Jan 17, 2022

Test metabase.api.session-test/failure-threshold-per-request-source fails sporadically due to a timing issue.
As this test is not related with Exasol we have deactivated the test. As soon as Metabase fixes this we can re-activate the test.

 FAIL in metabase.api.session-test/failure-threshold-per-request-source (session_test.clj:182)
The same as above, but ensure that throttling is done on a per request source basis.
expected: #"^Too many attempts! You must wait 1\d seconds before trying again\.$"
  actual: "Too many attempts! You must wait 9 seconds before trying again."
FAIL in metabase.api.notify-test/post-db-id-test (notify_test.clj:62)

:exasol full db sync by default
expected: (clojure.core/deref full-sync?)
  actual: (not (clojure.core/deref #<Atom@3fc4271b true>))

See discussion at https://discourse.metabase.com/t/sporadically-failing-metabase-tests/18408

@kaklakariada kaklakariada added bug Something isn't working source:exasol labels Jan 17, 2022
kaklakariada added a commit that referenced this issue Jan 17, 2022
kaklakariada added a commit that referenced this issue Jan 17, 2022
* Allow skipping build when running integration tests

* Add known issue for scanning GEOMETRY columns

* Change special types to :type/*

* Speedup setup of Exasol db

* Deactivate flaky test

#21

* Review finding: add link to user guide

Co-authored-by: jakobbraun <jakob.braun@posteo.de>
@kaklakariada kaklakariada self-assigned this Mar 29, 2022
kaklakariada added a commit that referenced this issue Mar 29, 2022
kaklakariada added a commit that referenced this issue Mar 29, 2022
* #21: Upgrade dependencies

* #21: Remove exclusion for flaky tests

* Add exclusion: Exasol does not support '.' in quoted identifiers

* #12 Remove exclusion for remapping test

* Update version to 1.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant