Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement reading JDBC driver version via Reflection #43

Closed
2 tasks done
kaklakariada opened this issue May 25, 2022 · 0 comments · Fixed by #46
Closed
2 tasks done

Implement reading JDBC driver version via Reflection #43

kaklakariada opened this issue May 25, 2022 · 0 comments · Fixed by #46
Assignees
@kaklakariada
Labels
bug Something isn't working

Comments

@kaklakariada
Copy link
Collaborator

kaklakariada commented May 25, 2022 •
edited
Loading

During implementation of #41 / #42 the function to log the Exasol JDBC driver version was lost.
Due to dependency issues we can't have a compile time dependency on the JDBC driver, instead we need to use reflection.

AC

  • The driver gets the JDBC driver version via reflection
  • Failures (e.g. missing driver on classpath) are handled gracefully without throwing an exception

See also #40
@kaklakariada kaklakariada added the bug Something isn't working label May 25, 2022
@kaklakariada kaklakariada self-assigned this May 30, 2022
kaklakariada added a commit that referenced this issue May 30, 2022
@kaklakariada
#43 Read JDBC driver version via reflection
0473f84
@kaklakariada kaklakariada mentioned this issue May 30, 2022
Merged
kaklakariada added a commit that referenced this issue May 30, 2022
@kaklakariada
#43 Update changelog
fa79077
kaklakariada added a commit that referenced this issue May 30, 2022
@kaklakariada
#43 Read JDBC driver version via reflection (#46)
850b2af 
* #43 Read JDBC driver version via reflection

* #43 Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaklakariada kaklakariada

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#43 Read JDBC driver version via reflection exasol/metabase-driver
1 participant
@kaklakariada