Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#269: Remove deprecated methods/fields #281

Merged
merged 3 commits into from
Apr 22, 2024
Merged

#269: Remove deprecated methods/fields #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eeff477
#269: Remove deprecated methods/fields
kaklakariada Apr 22, 2024
fbe460d
Fix test case
kaklakariada Apr 22, 2024
159716b
Improve changelog entry
kaklakariada Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions doc/changes/changes_17.1.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,15 @@ This release adds support for scalar function [`WIDTH_BUCKET`](https://docs.exas
* `ScalarFunctionCapability.WIDTH_BUCKET`
* `ScalarFunction.WIDTH_BUCKET`

**Breaking Changes:** This release removes the following deprecated fields/methods from class `com.exasol.adapter.AdapterProperties`:
* Constant `EXCEPTION_HANDLING_PROPERTY`
* Method `getExceptionHandling()`
* Method `hasExceptionHandling()`

## Breaking Changes

* #269: Removed deprecated exception handling fields/methods from `AdapterProperties`

## Features

* #278: Added support for scalar function `WIDTH_BUCKET`
Expand Down
29 changes: 0 additions & 29 deletions src/main/java/com/exasol/adapter/AdapterProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,6 @@ public class AdapterProperties extends AbstractAdapterProperties {
* The constant EXCLUDED_CAPABILITIES_PROPERTY.
*/
public static final String EXCLUDED_CAPABILITIES_PROPERTY = "EXCLUDED_CAPABILITIES";
/**
* The constant EXCEPTION_HANDLING_PROPERTY.
*
* @deprecated this will be removed in the next release
*/
@Deprecated(forRemoval = true)
public static final String EXCEPTION_HANDLING_PROPERTY = "EXCEPTION_HANDLING";
/**
* The constant IGNORE_ERRORS_PROPERTY.
*/
Expand Down Expand Up @@ -114,17 +107,6 @@ public String getExcludedCapabilities() {
return get(EXCLUDED_CAPABILITIES_PROPERTY);
}

/**
* Get the exception handling
*
* @return exception handling
* @deprecated this will be removed in the next release
*/
@Deprecated(forRemoval = true)
public String getExceptionHandling() {
return get(EXCEPTION_HANDLING_PROPERTY);
}

/**
* Get the list of ignored errors
*
Expand Down Expand Up @@ -229,17 +211,6 @@ public boolean hasExcludedCapabilities() {
return containsKey(EXCLUDED_CAPABILITIES_PROPERTY);
}

/**
* Check if the exception handling property is set
*
* @return <code>true</code> if exception handling property is set
* @deprecated this will be removed in the next release
*/
@Deprecated(forRemoval = true)
public boolean hasExceptionHandling() {
return containsKey(EXCEPTION_HANDLING_PROPERTY);
}

/**
* Check if the ignore errors property is set
*
Expand Down
4 changes: 1 addition & 3 deletions src/test/java/com/exasol/adapter/AdapterPropertiesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,8 @@ void testEmptyProperties() {
assertThat(AdapterProperties.emptyProperties(), equalTo(new AdapterProperties(Collections.emptyMap())));
}

@SuppressWarnings("removal") // EXCEPTION_HANDLING_PROPERTY will be removed in
// https://github.com/exasol/virtual-schema-common-java/issues/269
@ValueSource(strings = { CATALOG_NAME_PROPERTY, SCHEMA_NAME_PROPERTY, CONNECTION_NAME_PROPERTY,
DEBUG_ADDRESS_PROPERTY, LOG_LEVEL_PROPERTY, EXCLUDED_CAPABILITIES_PROPERTY, EXCEPTION_HANDLING_PROPERTY })
DEBUG_ADDRESS_PROPERTY, LOG_LEVEL_PROPERTY, EXCLUDED_CAPABILITIES_PROPERTY })
@ParameterizedTest
void testGetStringProperty(final String property) throws IllegalAccessException, IllegalArgumentException,
InvocationTargetException, NoSuchMethodException, SecurityException {
Expand Down