#156 - remove deprecated property EXCEPTION_HANDLING

exasol · Dec 21, 2023 · a247dad · a247dad
1 parent c52ca66
commit a247dad
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/src/main/java/com/exasol/adapter/dialects/AbstractSqlDialect.java b/src/main/java/com/exasol/adapter/dialects/AbstractSqlDialect.java
@@ -72,7 +72,6 @@ protected AbstractSqlDialect(final ConnectionFactory connectionFactory, final Ad
                 .add(PropertyValidator.forStructureElement(supportsJdbcCatalogs(), "catalogs", CATALOG_NAME_PROPERTY))
                 .add(DebugPortNumberProperty.validator()) //
                 .add(PropertyValidator.forStructureElement(supportsJdbcSchemas(), "schemas", SCHEMA_NAME_PROPERTY))
-                .add(ExceptionHandlingProperty.validator()) //
                 .add(DataTypeDetection.getValidator()) //
                 .add(TableCountLimit.getValidator()) //
                 .addAll(dialectSpecificPropertyValidators);

diff --git a/src/test/java/com/exasol/adapter/dialects/AbstractSqlDialectTest.java b/src/test/java/com/exasol/adapter/dialects/AbstractSqlDialectTest.java
@@ -160,11 +160,6 @@ void testStructureElementProperty(final String propertyName) {
         verifyValidationException(propertyName, "", "E-VSCJDBC-44");
     }
 
-    @Test
-    void testValidateExceptionHandling() {
-        verifyValidationException(EXCEPTION_HANDLING_PROPERTY, "unknown mode", "E-VSCJDBC-16");
-    }
-
     @Test
     void validateDataTypeDetectionStrategy() {
         verifyValidationException(DataTypeDetection.STRATEGY_PROPERTY, "unknown strategy", "E-VSCJDBC-41");

diff --git a/src/test/java/com/exasol/adapter/dialects/dummy/DummySqlDialect.java b/src/test/java/com/exasol/adapter/dialects/dummy/DummySqlDialect.java
@@ -1,6 +1,7 @@
 package com.exasol.adapter.dialects.dummy;
 
-import static com.exasol.adapter.AdapterProperties.*;
+import static com.exasol.adapter.AdapterProperties.CATALOG_NAME_PROPERTY;
+import static com.exasol.adapter.AdapterProperties.SCHEMA_NAME_PROPERTY;
 
 import java.sql.SQLException;
 import java.util.Set;
@@ -17,8 +18,7 @@ public class DummySqlDialect extends AbstractSqlDialect {
     static final String NAME = "DUMMYDIALECT";
 
     public DummySqlDialect(final ConnectionFactory connectionFactory, final AdapterProperties properties) {
-        super(connectionFactory, properties,
-                Set.of(SCHEMA_NAME_PROPERTY, CATALOG_NAME_PROPERTY, EXCEPTION_HANDLING_PROPERTY));
+        super(connectionFactory, properties, Set.of(SCHEMA_NAME_PROPERTY, CATALOG_NAME_PROPERTY));
     }
 
     @Override