Skip to content

Commit

Permalink
#147 Remove duplicate documentation (#148)
Browse files Browse the repository at this point in the history
  • Loading branch information
kaklakariada authored Jul 7, 2023
1 parent 214fc44 commit f0b9c7d
Show file tree
Hide file tree
Showing 11 changed files with 90 additions and 137 deletions.
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
# Eclipse and Maven
.classpath
.project
.settings/org.eclipse.core.resources.prefs
.settings/org.eclipse.jdt.apt.core.prefs
.settings/org.eclipse.m2e.core.prefs
# .settings : we need Eclipse settings for code formatter and clean-up rules
target
.cache
Expand Down
6 changes: 0 additions & 6 deletions .settings/org.eclipse.core.resources.prefs

This file was deleted.

4 changes: 0 additions & 4 deletions .settings/org.eclipse.m2e.core.prefs

This file was deleted.

34 changes: 19 additions & 15 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,17 +1,21 @@
{
"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
"source.organizeImports": true,
"source.generate.finalModifiers": true,
"source.fixAll": true
},
"java.codeGeneration.useBlocks": true,
"java.saveActions.organizeImports": true,
"java.sources.organizeImports.starThreshold": 3,
"java.sources.organizeImports.staticStarThreshold": 3,
"java.test.config": {
"vmArgs": [
"-Djava.util.logging.config.file=src/test/resources/logging.properties"
]
},
"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
"source.organizeImports": true,
"source.generate.finalModifiers": true,
"source.fixAll": true
},
"java.codeGeneration.useBlocks": true,
"java.saveActions.organizeImports": true,
"java.sources.organizeImports.starThreshold": 3,
"java.sources.organizeImports.staticStarThreshold": 3,
"java.test.config": {
"vmArgs": [
"-Djava.util.logging.config.file=src/test/resources/logging.properties"
]
},
"sonarlint.connectedMode.project": {
"connectionId": "exasol",
"projectKey": "com.exasol:virtual-schema-common-jdbc"
}
}
56 changes: 28 additions & 28 deletions dependencies.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions doc/changes/changelog.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 26 additions & 0 deletions doc/changes/changes_11.0.1.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# Virtual Schema Common JDBC 11.0.1, released 2023-??-??

Code name:

## Summary

## Documentation

* #147: Removed duplicate documentation about logging

## Dependency Updates

### Plugin Dependency Updates

* Updated `com.exasol:error-code-crawler-maven-plugin:1.2.3` to `1.3.0`
* Updated `com.exasol:project-keeper-maven-plugin:2.9.8` to `2.9.9`
* Updated `org.apache.maven.plugins:maven-clean-plugin:3.1.0` to `2.5`
* Updated `org.apache.maven.plugins:maven-gpg-plugin:3.0.1` to `3.1.0`
* Updated `org.apache.maven.plugins:maven-install-plugin:2.5.2` to `2.4`
* Updated `org.apache.maven.plugins:maven-resources-plugin:3.2.0` to `2.6`
* Updated `org.apache.maven.plugins:maven-site-plugin:3.9.1` to `3.3`
* Updated `org.apache.maven.plugins:maven-surefire-plugin:3.0.0` to `3.1.2`
* Updated `org.basepom.maven:duplicate-finder-maven-plugin:1.5.1` to `2.0.1`
* Updated `org.codehaus.mojo:flatten-maven-plugin:1.4.1` to `1.5.0`
* Updated `org.codehaus.mojo:versions-maven-plugin:2.15.0` to `2.16.0`
* Updated `org.jacoco:jacoco-maven-plugin:0.8.9` to `0.8.10`
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ Athena (at least with driver version 2.0.7) is one of the rare examples, where t
Looking at the documentation, we can see that the recommended way to list tables is issuing a [`SHOW TABLES`](https://docs.aws.amazon.com/athena/latest/ug/show-tables.html) command.
If you ever worked with [MySQL](https://www.mysql.com/) this might [look familiar](https://dev.mysql.com/doc/refman/8.0/en/show-tables.html).

The best way to check if your source can find metadata with the default settings — run the first manual [integration test](integration_testing.md) with [remote logging](remote_logging.md).
The best way to check if your source can find metadata with the default settings — run the first manual [integration test](integration_testing.md) with [remote logging](https://docs.exasol.com/db/latest/database_concepts/virtual_schema/logging.htm).
If you can **access metadata** using the default implementation, go to the next checkpoint: [Data Type Conversion](#implementing-data-type-conversion).
Otherwise we have to implement metadata handling:

Expand Down Expand Up @@ -175,7 +175,7 @@ Be prepared that even if the remote data source implements an SQL standard type,
On for `VARCHAR` you also need to be aware of character set encoding. Exasol supports `UTF8` which should be able to receive data from any other character set and `ASCII` which is very limited but only uses a single byte per character.
There are differences in how precise the remote data source can encode integer, fixed point and floating values and so on.
The best way to find out how good the default mapping works for your source — run a manual [integration test](integration_testing.md) with [remote logging](remote_logging.md) accessing a table with all data types available in the source.
The best way to find out how good the default mapping works for your source — run a manual [integration test](integration_testing.md) with [remote logging](https://docs.exasol.com/db/latest/database_concepts/virtual_schema/logging.htm) accessing a table with all data types available in the source.
If you assume that you don't need to change data type conversion — go to the next checkpoint: [Implementing Query Rewriting](#implementing-query-rewriting)

Let's look at a HIVE dialect example. We only want to change mapping for two data type: DECIMAL and BINARY.
Expand Down
47 changes: 0 additions & 47 deletions doc/development/remote_logging.md

This file was deleted.

16 changes: 8 additions & 8 deletions pk_generated_parent.pom

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 3 additions & 27 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<artifactId>virtual-schema-common-jdbc</artifactId>
<version>11.0.0</version>
<version>11.0.1</version>
<name>Virtual Schema Common JDBC</name>
<description>Common module for JDBC-based data access from Virtual Schemas.</description>
<url>https://github.com/exasol/virtual-schema-common-jdbc/</url>
Expand Down Expand Up @@ -84,7 +84,7 @@
<plugin>
<groupId>com.exasol</groupId>
<artifactId>project-keeper-maven-plugin</artifactId>
<version>2.9.8</version>
<version>2.9.9</version>
<executions>
<execution>
<goals>
Expand All @@ -94,35 +94,11 @@
</executions>
</plugin>
</plugins>
<pluginManagement>
<plugins>
<plugin>
<artifactId>maven-clean-plugin</artifactId>
<version>3.1.0</version>
</plugin>
<plugin>
<artifactId>maven-deploy-plugin</artifactId>
<version>2.8.2</version>
</plugin>
<plugin>
<artifactId>maven-install-plugin</artifactId>
<version>2.5.2</version>
</plugin>
<plugin>
<artifactId>maven-resources-plugin</artifactId>
<version>3.2.0</version>
</plugin>
<plugin>
<artifactId>maven-site-plugin</artifactId>
<version>3.9.1</version>
</plugin>
</plugins>
</pluginManagement>
</build>
<parent>
<artifactId>virtual-schema-common-jdbc-generated-parent</artifactId>
<groupId>com.exasol</groupId>
<version>11.0.0</version>
<version>11.0.1</version>
<relativePath>pk_generated_parent.pom</relativePath>
</parent>
</project>

0 comments on commit f0b9c7d

Please sign in to comment.