Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate adding a dialect name to the factory list #10

Closed
AnastasiiaSergienko opened this issue Oct 25, 2019 · 0 comments · Fixed by #11
Closed

Automate adding a dialect name to the factory list #10

AnastasiiaSergienko opened this issue Oct 25, 2019 · 0 comments · Fixed by #11

Comments

@AnastasiiaSergienko
Copy link
Contributor

Problem

When we create a new dialect we have to add a dialect's name manually to the list in the method getSupportedAdapterNames() in the JdbcAdapterFactory class.

Solution

Automate this process.

This ticket was moved from: exasol/virtual-schema-common-java#115
@AnastasiiaSergienko AnastasiiaSergienko mentioned this issue Oct 25, 2019
Closed
redcatbear added a commit that referenced this issue Oct 25, 2019
@redcatbear
#10: Dialect name list now assembled at runtime.
3423a45
@redcatbear redcatbear mentioned this issue Oct 25, 2019
Merged
redcatbear added a commit that referenced this issue Oct 25, 2019
@redcatbear
#10: Updated formatting.
e5231a5
AnastasiiaSergienko added a commit that referenced this issue Oct 29, 2019
@AnastasiiaSergienko
#10: formatted project and imports with eclipse formatter
3bef8ec
redcatbear added a commit that referenced this issue Nov 12, 2019
@redcatbear
#10: Automatted dialect list detection
80d409e
AnastasiiaSergienko added a commit that referenced this issue Nov 13, 2019
@AnastasiiaSergienko
#10: changed vsc-java version
4f678e6
AnastasiiaSergienko added a commit that referenced this issue Nov 13, 2019
@AnastasiiaSergienko
#10: changed java version from 9 to 11
f8a986b
redcatbear added a commit that referenced this issue Nov 13, 2019
@redcatbear
#10: Fixed formatting.
631580d
AnastasiiaSergienko pushed a commit that referenced this issue Nov 13, 2019
@redcatbear @AnastasiiaSergienko
#10: Dialect name list now assembled at runtime. (#11)
c2f4ee3 
* #10: Dialect name list now assembled at runtime.
* #10: Automatted dialect list detection
* #12: Changed java version from 9 to 11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#10: Dialect name list now assembled at runtime. exasol/virtual-schema-common-jdbc
1 participant
@AnastasiiaSergienko