Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide the connectionDefinitionBuilder in AbstractQueryRewriter through DI instead of by subclassing #74

Closed
chiaradiamarcelo opened this issue Dec 9, 2020 · 0 comments · Fixed by #90
Closed

Provide the connectionDefinitionBuilder in AbstractQueryRewriter through DI instead of by subclassing #74

chiaradiamarcelo opened this issue Dec 9, 2020 · 0 comments · Fixed by #90
Labels
refactoring Code improvement without behavior change

Comments

@chiaradiamarcelo
Copy link
Contributor

The AbstractQueryRewriter uses internally a connectionDefinitionBuilder to build the connection definition string.

Every time we want/need a different implementation of the builder we are forced to subclass the QueryRewriter. We should provide the connectionDefinitionBuilder as a constructor parameter and let the client decide the right implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
1 participant
@chiaradiamarcelo