Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dialect-level plug-in mechanism #86

Closed
redcatbear opened this issue Jan 21, 2021 · 1 comment · Fixed by #87
Closed

Remove dialect-level plug-in mechanism #86

redcatbear opened this issue Jan 21, 2021 · 1 comment · Fixed by #87
Assignees
@redcatbear
Labels
refactoring Code improvement without behavior change

Comments

@redcatbear
Copy link
Collaborator

Situation

We extracted each dialect into its own repository. There is now a 1 : 1 relationship between adapter and dialect. This makes the current dialect loading superfluous.

Fixes #63.

Acceptance criteria

  • Dialect Registry is removed
  • Single dialect is injected
@redcatbear redcatbear self-assigned this Jan 21, 2021
@redcatbear redcatbear added the refactoring Code improvement without behavior change label Jan 21, 2021
redcatbear added a commit that referenced this issue Jan 22, 2021
@redcatbear
#86: Remove dialect-level plug-in mechanism
e232fd7
@redcatbear redcatbear mentioned this issue Jan 22, 2021
Merged
@chiaradiamarcelo
Copy link
Contributor

It also fixes #62.

This was referenced Jan 22, 2021
Closed
Closed
redcatbear added a commit that referenced this issue Jan 22, 2021
@redcatbear
#86: Removed superfluous implements in DerbyAdapter.
9c77c10
redcatbear added a commit that referenced this issue Jan 22, 2021
@redcatbear
#86: Remove dialect-level plug-in mechanism (#87)
2ed4c26 
* #86: Remove dialect-level plug-in mechanism
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redcatbear redcatbear

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#86: Remove dialect-level plug-in mechanism exasol/virtual-schema-common-jdbc
2 participants
@redcatbear @chiaradiamarcelo