Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#149: Workaround for GROUP BY <integer> #150

Merged
merged 6 commits into from
Jul 11, 2023
Merged

#149: Workaround for GROUP BY <integer> #150

merged 6 commits into from
Jul 11, 2023

Conversation

kaklakariada
Copy link
Contributor

Closes #149

@redcatbear
Copy link
Collaborator

Also I would feel better if you invested a little bit extra time into an integration test with Derby (already in the POM).

kaklakariada and others added 3 commits July 10, 2023 14:06
@kaklakariada
Copy link
Contributor Author

Integration tests with the Exasol require a lot of setup effort in this project. I will add integration tests in exasol/exasol-virtual-schema#108.

ckunki
ckunki previously requested changes Jul 10, 2023
View reviewed changes
doc/changes/changes_11.0.1.md Outdated Show resolved Hide resolved
redcatbear
redcatbear previously approved these changes Jul 10, 2023
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@kaklakariada kaklakariada dismissed ckunki’s stale review July 11, 2023 06:06

Review findings are addressed

@kaklakariada kaklakariada merged commit 255e547 into main Jul 11, 2023
@kaklakariada kaklakariada deleted the kaklakariada/issue149 branch July 11, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redcatbear redcatbear redcatbear approved these changes

@ckunki ckunki ckunki left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VS Workaround for GROUP BY <integer>
3 participants
@kaklakariada @redcatbear @ckunki