Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#56: Improved BaseColumnMetadataReader JDBC types mapping. #57

Merged
merged 2 commits into from
Aug 13, 2020
Merged

#56: Improved BaseColumnMetadataReader JDBC types mapping. #57

merged 2 commits into from
Aug 13, 2020

Conversation

AnastasiiaSergienko
Copy link
Contributor

@AnastasiiaSergienko AnastasiiaSergienko commented Aug 13, 2020 •
edited
Loading

Closes #56

@AnastasiiaSergienko AnastasiiaSergienko added the refactoring Code improvement without behavior change label Aug 13, 2020
@AnastasiiaSergienko AnastasiiaSergienko self-assigned this Aug 13, 2020
jakobbraun
jakobbraun suggested changes Aug 13, 2020
View reviewed changes
src/main/java/com/exasol/adapter/jdbc/BaseColumnMetadataReader.java Show resolved Hide resolved
src/test/java/com/exasol/adapter/jdbc/BaseColumnMetadataReaderTest.java Outdated
@@ -42,6 +42,21 @@ void testMappingUnsupportedTypesReturnsUnsupportedType(final int jdbcType) {
assertThat(this.reader.mapJdbcType(jdbcTypeDescription).getExaDataType(), equalTo(ExaDataType.UNSUPPORTED));
}

@ValueSource(ints = { Types.NUMERIC })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a parametrized test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Forgot to refactor it after removing types

@jakobbraun jakobbraun requested review from jakobbraun and removed request for jakobbraun August 13, 2020 13:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@AnastasiiaSergienko AnastasiiaSergienko merged commit 4ec1dfb into master Aug 13, 2020
@AnastasiiaSergienko AnastasiiaSergienko deleted the refactoring/56_improve_jdbc_types_mapping branch August 13, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobbraun jakobbraun jakobbraun approved these changes

Assignees

@AnastasiiaSergienko AnastasiiaSergienko

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve BaseColumnMetadataReader JDBC types mapping
2 participants
@AnastasiiaSergienko @jakobbraun