Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#69: Fixed wrong error message #70

Merged
merged 4 commits into from
Nov 30, 2020
Merged

Conversation

jakobbraun
Copy link
Contributor

Closes #69

@jakobbraun jakobbraun self-assigned this Nov 30, 2020
@jakobbraun jakobbraun added the bug Unwanted / harmful behavior label Nov 30, 2020
Copy link
Contributor

@chiaradiamarcelo chiaradiamarcelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge once you fixed the imports

import com.exasol.adapter.sql.AggregateFunction;
import com.exasol.adapter.sql.ScalarFunction;
import com.exasol.adapter.sql.SqlNodeVisitor;
import com.exasol.adapter.sql.SqlStatement;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have a problem with the formatter here. This should compress to a single import as it was before

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I formated again using the latest configuration. Seems like it is currently configured like that

@jakobbraun jakobbraun mentioned this pull request Nov 30, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

@jakobbraun jakobbraun merged commit a93bd3e into main Nov 30, 2020
@jakobbraun jakobbraun deleted the bug/69-wrong-error-message branch November 30, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unwanted / harmful behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong error message generated by validateCastNumberToDecimalProperty
2 participants