Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract common JDBC parts to separate Maven module #280

Closed
redcatbear opened this issue Oct 15, 2019 · 0 comments · Fixed by #285
Closed

Extract common JDBC parts to separate Maven module #280

redcatbear opened this issue Oct 15, 2019 · 0 comments · Fixed by #285
Assignees
@redcatbear
Labels
refactoring Code improvement without behavior change

Comments

@redcatbear
Copy link
Collaborator

Situation

This repository contains JDBC-based code that is useful for other kinds of Virtual Schemas that is useful for other Virtual Schema implementations (e.g. row level security). Instead of copying the code we should move the common part to a common Maven module.

Acceptance Criteria

  1. Common parts offering JDBC access features are extracted to a separate Maven module
@redcatbear redcatbear added the refactoring Code improvement without behavior change label Oct 15, 2019
@redcatbear redcatbear self-assigned this Oct 16, 2019
redcatbear added a commit to exasol/virtual-schema-common-jdbc that referenced this issue Oct 16, 2019
@redcatbear
#280: Basic extraction (2 unit tests failing).
389c18b 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit to exasol/java-util-logging-testing that referenced this issue Oct 17, 2019
@redcatbear
#280: Extract common JDBC parts to separate Maven module
c0236eb 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit to exasol/java-util-logging-testing that referenced this issue Oct 17, 2019
@redcatbear
#280: Added README and Travis CI configuration.
1244e7f 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit to exasol/virtual-schema-common-jdbc that referenced this issue Oct 17, 2019
@redcatbear
#280: Extract common JDBC parts to separate Maven module
dbcedc9 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit to exasol/java-util-logging-testing that referenced this issue Oct 18, 2019
@redcatbear
#280: Set version number to 1.0.0 and added SonarCloud token.
32e4bba 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit to exasol/java-util-logging-testing that referenced this issue Oct 18, 2019
@redcatbear
#280: Updated SonarCloud token.
a49ec6a 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit to exasol/java-util-logging-testing that referenced this issue Oct 18, 2019
@redcatbear
#280: Added quotes and updated SonarCloud token.
6d320c2 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit to exasol/java-util-logging-testing that referenced this issue Oct 18, 2019
@redcatbear
#280: Added Sonar project key.
b3e3638 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit to exasol/java-util-logging-testing that referenced this issue Oct 18, 2019
@redcatbear
#280: Moved token from config file to Travis CI service.
d1d29df 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit to exasol/java-util-logging-testing that referenced this issue Oct 18, 2019
@redcatbear
#280: Another attempt with a differently encrypted token.
54ea033 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit to exasol/java-util-logging-testing that referenced this issue Oct 18, 2019
@redcatbear
#280: Another attempt with token as Travis variable.
cb239b6 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit to exasol/java-util-logging-testing that referenced this issue Oct 18, 2019
@redcatbear
#280: Added unit test to improve test coverage.
121cac7 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit to exasol/java-util-logging-testing that referenced this issue Oct 18, 2019
@redcatbear
#280: Updated build dependencies.
fb79ccc 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit to exasol/java-util-logging-testing that referenced this issue Oct 18, 2019
@redcatbear
#280: Testing close() function.
259fdb8 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit to exasol/java-util-logging-testing that referenced this issue Oct 18, 2019
@redcatbear
#280: Extract common JDBC parts to separate Maven module
0a8f7d4 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit to exasol/virtual-schema-common-jdbc that referenced this issue Oct 18, 2019
@redcatbear
#280: Removed compiler warnings, fixed unit tests.
56ab41c 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit to exasol/virtual-schema-common-jdbc that referenced this issue Oct 18, 2019
@redcatbear
#280: Removed AbstractIntegrationTest and broken JavaDoc reference.
0b358d5 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit to exasol/virtual-schema-common-jdbc that referenced this issue Oct 18, 2019
@redcatbear
#280: Removed IntegrationTestConfigurationCondition.
c3a7907 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit that referenced this issue Oct 21, 2019
@redcatbear
#280: Extract common JDBC parts to separate Maven module
1300998 
Task-Url: #280
redcatbear added a commit to exasol/virtual-schema-common-jdbc that referenced this issue Oct 21, 2019
@redcatbear
#280: Extract common JDBC parts to separate Maven module
5cf69b8 
Task-Url: exasol/virtual-schemas#280
@redcatbear redcatbear mentioned this issue Oct 21, 2019
Merged
redcatbear added a commit to exasol/java-util-logging-testing that referenced this issue Oct 21, 2019
@redcatbear
#280: Updated Eclipse settings to enforce Java 9.
cd5f809 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit to exasol/java-util-logging-testing that referenced this issue Oct 21, 2019
@redcatbear
Updated Eclipse classpath
9b6548f 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit to exasol/virtual-schema-common-jdbc that referenced this issue Oct 21, 2019
@redcatbear
#280: Improved dialect loading Message. Merged HASHTYPE.
fc4f7da 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit that referenced this issue Oct 21, 2019
@redcatbear
#280: Extract common JDBC parts to separate Maven module.
b549ad7 
Task-Url: #280
redcatbear added a commit to exasol/virtual-schema-common-jdbc that referenced this issue Oct 21, 2019
@redcatbear
#280: Added missing POM details in preparation of deploying to the Ce…
e2286fd 
…ntral Repository.

Task-Url: exasol/virtual-schemas#280
redcatbear added a commit to exasol/virtual-schema-common-jdbc that referenced this issue Oct 21, 2019
@redcatbear
#280: Added formatter settings and save actions.
0a312a9 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit to exasol/java-util-logging-testing that referenced this issue Oct 21, 2019
@redcatbear
#280: Added formatter settings and save actions.
55711b6 
Task-Url: exasol/virtual-schemas#280
redcatbear added a commit that referenced this issue Oct 22, 2019
@redcatbear
#280: Updated versions.
429eb12 
Task-Url: #280
@redcatbear redcatbear mentioned this issue Oct 22, 2019
Merged
AnastasiiaSergienko added a commit that referenced this issue Oct 23, 2019
@AnastasiiaSergienko
#280: added SqlStatementSelect.Builder
4666e4e
redcatbear added a commit that referenced this issue Nov 12, 2019
@redcatbear
#280: Used new dialect detection from virtual-schema-common-jdbc.
9f7b04f
redcatbear added a commit that referenced this issue Dec 11, 2019
@redcatbear
#280: Updated version numbers to latest common parts.
32a7f9f
redcatbear added a commit that referenced this issue Dec 11, 2019
@redcatbear
#280: Fixed review findings.
3668654
redcatbear added a commit that referenced this issue Dec 11, 2019
@redcatbear
#280: Updated to Java 11.
2a1b03b
redcatbear added a commit that referenced this issue Dec 11, 2019
@redcatbear
#280: Updated Travis and Eclipse files for Java 11.
fe238b4
AnastasiiaSergienko pushed a commit that referenced this issue Dec 11, 2019
@redcatbear @AnastasiiaSergienko
Refactoring/280 extract common jdbc parts to separate maven module (#285
5002c79 
)

* #280: Extract common JDBC parts to separate Maven module.
* #280: Added SqlStatementSelect.Builder.
* #280: Used new dialect detection from `virtual-schema-common-jdbc`.
* #280: Updated Travis and Eclipse files for Java 11.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redcatbear redcatbear

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactoring/280 extract common jdbc parts to separate maven module exasol/virtual-schemas
1 participant
@redcatbear