Skip to content

Commit

Permalink
[#953] Fix call to comply with audio deprecation warning (#961)
Browse files Browse the repository at this point in the history
  • Loading branch information
eonarheim authored and jedeen committed Apr 19, 2018
1 parent 4297ca8 commit 61037e9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).

## Fixed
- Added missing variable assignments to TileMapImpl constructor ([#957](https://github.com/excaliburjs/Excalibur/pull/957))
- Correct setting audio volume level from `value` to `setValueAtTime` to comply with deprecation warning in Chrome 59 ([#953](https://github.com/excaliburjs/Excalibur/pull/953))

<!--------------------------------- DO NOT EDIT BELOW THIS LINE --------------------------------->

Expand Down
3 changes: 2 additions & 1 deletion src/engine/Resources/Sound.ts
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,8 @@ class WebAudioInstance implements IAudio {
this._bufferSource = audioContext.createBufferSource();
this._bufferSource.buffer = this._buffer;
this._bufferSource.loop = this._loop;
this._bufferSource.playbackRate.value = 1.0;
this._bufferSource.playbackRate.setValueAtTime(1.0, 0);

this._bufferSource.connect(this._volumeNode);
}

Expand Down

0 comments on commit 61037e9

Please sign in to comment.