fix: [#2535] Update to default false on cache busting (#2663)

Closes #2535

This PR updates `bustCache= false` by default and provides a `bustCache` property on all built in `Resource` implementations.

CHANGELOG.md

@@ -79,7 +79,7 @@ stored `ex.Graphics` causing them to be shared across clones.
 
 ### Changed
 
--
+- Excalibur resources by default no longer add cache busting query string to resources. All built in resources now expose a `bustCache` property to allow setting this before loading, for example `ex.Sound.bustCache`.
 
 
 

src/engine/Graphics/ImageSource.ts

@@ -66,6 +66,18 @@ export class ImageSource implements Loadable<HTMLImageElement> {
     }
   }
 
+  /**
+   * Should excalibur add a cache busting querystring? By default false.
+   * Must be set before loading
+   */
+  public get bustCache() {
+    return this._resource.bustCache;
+  }
+
+  public set bustCache(val: boolean) {
+    this._resource.bustCache = val;
+  }
+
   /**
    * Begins loading the image and returns a promise that resolves when the image is loaded
    */

src/engine/Resources/Gif.ts

@@ -38,11 +38,23 @@ export class Gif implements Loadable<ImageSource[]> {
    * @param color      Optionally set the color to treat as transparent the gif, by default [[Color.Magenta]]
    * @param bustCache  Optionally load texture with cache busting
    */
-  constructor(public path: string, public color: Color = Color.Magenta, public bustCache = true) {
+  constructor(public path: string, public color: Color = Color.Magenta, bustCache = false) {
     this._resource = new Resource(path, 'arraybuffer', bustCache);
     this._transparentColor = color;
   }
 
+  /**
+   * Should excalibur add a cache busting querystring? By default false.
+   * Must be set before loading
+   */
+  public get bustCache() {
+    return this._resource.bustCache;
+  }
+
+  public set bustCache(val: boolean) {
+    this._resource.bustCache = val;
+  }
+
   /**
    * Begins loading the texture and returns a promise to be resolved on completion
    */

src/engine/Resources/Resource.ts

@@ -19,7 +19,7 @@ export class Resource<T> implements Loadable<T> {
   constructor(
     public path: string,
     public responseType: '' | 'arraybuffer' | 'blob' | 'document' | 'json' | 'text',
-    public bustCache: boolean = true
+    public bustCache: boolean = false
   ) {}
 
   /**

src/engine/Resources/Sound/Sound.ts

@@ -84,6 +84,19 @@ export class Sound extends Class implements Audio, Loadable<AudioBuffer> {
     this._resource.path = val;
   }
 
+
+  /**
+   * Should excalibur add a cache busting querystring? By default false.
+   * Must be set before loading
+   */
+  public get bustCache() {
+    return this._resource.bustCache;
+  }
+
+  public set bustCache(val: boolean) {
+    this._resource.bustCache = val;
+  }
+
   private _loop = false;
   private _volume = 1;
   private _isStopped = false;