Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offscreen culling kicking in too early #1078

Closed
mjkayson opened this issue Dec 19, 2018 · 1 comment
Closed

Offscreen culling kicking in too early #1078

mjkayson opened this issue Dec 19, 2018 · 1 comment
Assignees
@eonarheim
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior priority 1 Excalibur is unusable in most use cases or severely degraded
Milestone
0.21.0 Release

Comments

@mjkayson
Copy link

mjkayson commented Dec 19, 2018 •
edited by jedeen
Loading

Steps to Reproduce

See the pen here: https://codepen.io/mjkayson/pen/YdzEpZ (it gradually zooms in and out)

Expected Result

Ideally (for me at least) culling would happen a fair while after the actor is outside the field of view - also would be nice to have a flag to disable culling on a given actor.

Actual Result

Actors are being culled while still visible when the camera zooms in, and when zooming out they pop back in after their position is within the visible area.

Environment

  • Excalibur versions: 0.19.0, 0.19.1
@eonarheim eonarheim added the bug This issue describes undesirable, incorrect, or unexpected behavior label Dec 21, 2018
@eonarheim eonarheim added this to the 0.21.0 Release milestone Dec 21, 2018
@jedeen
Copy link
Member

jedeen commented Dec 21, 2018

Hi! Thanks for submitting this issue. I've updated the comment to use our bug template, and we've confirmed and prioritized this bug for our next release. Thanks again!

@eonarheim eonarheim self-assigned this Dec 28, 2018
eonarheim added a commit that referenced this issue Dec 29, 2018
@eonarheim
[#1078] Fix issue early offscreen culling related to zoom
71c2f9f
@eonarheim eonarheim mentioned this issue Dec 29, 2018
Merged
6 tasks
@eonarheim eonarheim added the priority 1 Excalibur is unusable in most use cases or severely degraded label Jan 24, 2019
eonarheim added a commit that referenced this issue Jan 28, 2019
@eonarheim
[#1078] Fix issue early offscreen culling related to zoom (#1081)
6ae1e37 
Closes #1078

## Changes:

- Add new `viewport` property to camera to return a world space bounding box of the current visible area
- Add visual tests
eonarheim added a commit that referenced this issue Feb 2, 2019
@eonarheim
[#1078] Fix issue with offscreen culling on left side of screen
75f8379
@eonarheim eonarheim mentioned this issue Feb 2, 2019
Merged
4 tasks
eonarheim added a commit that referenced this issue Feb 2, 2019
@eonarheim
[#1078] Fix issue with offscreen culling on left side of screen (#1099)
051b0ef 
Closes #1078 

## Changes:

- Correct left side viewport calculation
- Add tests for all sides of culling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eonarheim eonarheim

Labels
bug This issue describes undesirable, incorrect, or unexpected behavior priority 1 Excalibur is unusable in most use cases or severely degraded
Projects
None yet
Milestone
0.21.0 Release
Development

No branches or pull requests
3 participants
@eonarheim @jedeen @mjkayson