Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excalibur Engine.suppressPlayButton = true will not work in Chrome #1079

Closed
eonarheim opened this issue Dec 24, 2018 · 0 comments
Closed

Excalibur Engine.suppressPlayButton = true will not work in Chrome #1079

eonarheim opened this issue Dec 24, 2018 · 0 comments
Assignees
@eonarheim
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior priority 1 Excalibur is unusable in most use cases or severely degraded
Milestone
0.21.0 Release

Comments

@eonarheim
Copy link
Member

Steps to Reproduce

Setting suppressPlayButton = true on engine causes the loading bar in Chrome to freeze, because the Chrome audio context is blocked from loading.

https://codepen.io/eonarheim/pen/mamYbz?editors=0011

Expected Result

Loading bar should continue loading with an audio warning in the console

Actual Result

Engine is stuck

Environment

  • browsers and versions: Chrome 71
  • operating system: Windows
  • Excalibur versions: master

Current Workaround

None
@eonarheim eonarheim added the bug This issue describes undesirable, incorrect, or unexpected behavior label Dec 24, 2018
@eonarheim eonarheim added this to the 0.21.0 Release milestone Dec 24, 2018
eonarheim added a commit that referenced this issue Dec 24, 2018
@eonarheim
[#1079] Fix issue where suppressPlayButton blocks load
697f22d
@eonarheim eonarheim mentioned this issue Dec 24, 2018
Merged
4 tasks
@eonarheim eonarheim self-assigned this Jan 4, 2019
eonarheim added a commit that referenced this issue Jan 10, 2019
@eonarheim
[#1079] Fix issue where suppressPlayButton blocks load
e260698
@eonarheim eonarheim added the priority 1 Excalibur is unusable in most use cases or severely degraded label Jan 24, 2019
eonarheim added a commit that referenced this issue Jan 28, 2019
@eonarheim
[#1079] Fix issue where suppressPlayButton blocks load (#1080)
b210b21 
Closes #1079

## Changes:

- Adds a AudioContext resume timeout, after which the load will be continued
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eonarheim eonarheim

Labels
bug This issue describes undesirable, incorrect, or unexpected behavior priority 1 Excalibur is unusable in most use cases or severely degraded
Projects
None yet
Milestone
0.21.0 Release
Development

No branches or pull requests
1 participant
@eonarheim