Passing a Data URI to Texture constructor hangs Loader (and isLoaded() never returns true)

[thomergil]

If I'm reading the Texture constructor correctly, it should be able to handle Data URI as path. However, this hangs the loader forever.

export const Images: { [key: string]: ex.Texture } = {
    failure: new ex.Texture(
        'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAANwAAADcCAYAAAAbWs+BAAAABmJLR0QA/wD/AP+gvaeTAAAACXBIWXMAAAsTAAALEwEAmpwYAAAAB3RJTUUH4gIUARQAHY8+4wAAApBJREFUeNrt3cFqAjEUhlEjvv8rXz
    ),
};

const allResources = { ...Images };
export const loader = new ex.Loader();
loader.suppressPlayButton = true;

for (const res in allResources) {
    loader.addResource(allResources[res]);
}

game.start(loader).then(function () { /* */ }

Invoking .load() on a Texture object that was constructed with a Data URI never returns true for .isLoaded().

One thing that catches my attention in Texture's constructor is that it appears that:

            this._isLoaded = true;

...is called for path that is not a Data URI, but it is never called for a path that is a Data URI. See https://github.com/excaliburjs/Excalibur/blob/57e03f4d/src/engine/Resources/Texture.ts#L73

[eonarheim]

Good find, that shouldn't happen

[thomergil]

I believe the fix might be adding this._isLoaded = true; in the part of the constructor that deals with a Data URI path. (Though I don't have enough understanding of the code yet whether that will resolve the hanging Loader; I have to assume that something polls all resources until isLoaded() == true, though?)

[thomergil]

My suggested fix does not, in fact, resolve the hanging loader problem.

[eonarheim]

I wonder if it's a missing promise resolve() that should fire when a data URI is passed

…

On Wed, May 13, 2020 at 10:34 AM Thomer Gil ***@***.***> wrote: My suggested fix does not, in fact, resolve the hanging loader problem. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1543 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEVNZYSOHYO5MZITYLKWCDRRK4ZPANCNFSM4M7H7RZQ> .

[thomergil]

I think it's there: https://github.com/excaliburjs/Excalibur/blob/master/src/engine/Resources/Texture.ts#L64

[thomergil]

Awesome.