Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animations with invalid SpriteSheet indices should warn #1856

Closed
eonarheim opened this issue Apr 30, 2021 · 1 comment · Fixed by #1956
Closed

Animations with invalid SpriteSheet indices should warn #1856

eonarheim opened this issue Apr 30, 2021 · 1 comment · Fixed by #1956
Labels
stale This issue or PR has not had any activity recently

Comments

@eonarheim
Copy link
Member

Context

It is easy to typo sprite sheet indices when building an animation.

Proposal

Animations should warn that there is no image at that index if an invalid one is supplied.

Bonus: one "feature" of an invalid index is it displays nothing, perhaps we should have a special index, -1? that is for displaying an empty frame.
@github-actions
Copy link

This issue hasn't had any recent activity lately and is being marked as stale automatically.

@github-actions github-actions bot added the stale This issue or PR has not had any activity recently label Jun 30, 2021
eonarheim added a commit that referenced this issue Jul 2, 2021
@eonarheim
feat: [#1856] Log warning on invalid spritesheet indices
08d937a
@eonarheim eonarheim mentioned this issue Jul 2, 2021
Merged
5 tasks
eonarheim added a commit that referenced this issue Jul 2, 2021
@eonarheim
feat: [#1856] Log warning on invalid spritesheet indices (#1956)
bcd269a 
Closes #1856

## Changes:

- Logs warning on invalid spritesheet indices
- Test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale This issue or PR has not had any activity recently
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: [#1856] Log warning on invalid spritesheet indices excaliburjs/Excalibur
1 participant
@eonarheim