Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actor PreDraw/PostDraw events not working, or are incorrectly typed #2854

Closed
mattjennings opened this issue Dec 26, 2023 · 1 comment · Fixed by #2860
Closed

Actor PreDraw/PostDraw events not working, or are incorrectly typed #2854

mattjennings opened this issue Dec 26, 2023 · 1 comment · Fixed by #2860
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior

Comments

@mattjennings
Copy link
Contributor

It seems there are predraw and postdraw events in the ActorEvents types, but I don't believe they are actually emitted.

I think these were added in the strong event types refactor - perhaps by accident, but FWIW it would be handy to have these events directly on the actor 😄

Steps to Reproduce

Add an event listener on the actor for predraw or postdraw

https://codesandbox.io/p/devbox/admiring-elion-dqsvzf?file=/index.js:23,1-26,8

Expected Result

Events should emit

Actual Result

Events do not emit

Environment

  • browsers and versions: Chromium 120.0.6099.129
  • operating system: macOS 14.2.1
  • Excalibur versions: 0.28.4
  • (anything else that may be relevant)

Current Workaround

N/A

@eonarheim
Copy link
Member

@mattjennings Good find! yup they should still emit! Should be an easy fix

@eonarheim eonarheim added the bug This issue describes undesirable, incorrect, or unexpected behavior label Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants