Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "priority" on System to be a static member #3102

Closed
mattjennings opened this issue Jun 18, 2024 · 3 comments · Fixed by #3207
Closed

Change "priority" on System to be a static member #3102

mattjennings opened this issue Jun 18, 2024 · 3 comments · Fixed by #3207
Labels
stale This issue or PR has not had any activity recently

Comments

@mattjennings
Copy link
Contributor

Context

This would make it much easier to specify a system to run before/after another system.

class SomeSystem extends ex.System {
    static priority = ex.MotionSystem.priority - 1
}
@eonarheim
Copy link
Member

I support this, you thinking like this?
image

This would definitely be a breaking change for anyone that's implemented a custom system

@mattjennings
Copy link
Contributor Author

Yup, exactly.

It appears you can actually have both an instance and static member of the same name (TIL), if we wanted to avoid the breaking change.

Copy link

This issue hasn't had any recent activity lately and is being marked as stale automatically.

@github-actions github-actions bot added the stale This issue or PR has not had any activity recently label Aug 18, 2024
Autsider666 added a commit to Autsider666/Excalibur that referenced this issue Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale This issue or PR has not had any activity recently
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants