Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graphic.tint nullability #3119

Closed
raylu opened this issue Jul 5, 2024 · 2 comments · Fixed by #3120
Closed

Graphic.tint nullability #3119

raylu opened this issue Jul 5, 2024 · 2 comments · Fixed by #3120
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior

Comments

@raylu
Copy link

raylu commented Jul 5, 2024

Graphic.tint is a non-nullable Color, but it starts as null and the way to remove tint from a graphic is to set it back to null
@eonarheim
Copy link
Member

Good find! Definitely a bug

@eonarheim eonarheim added the bug This issue describes undesirable, incorrect, or unexpected behavior label Jul 5, 2024
@eonarheim
Copy link
Member

We have loose types on parts of the project that allow these bugs to sneak through, adjusting this type should fix things. https://github.com/excaliburjs/Excalibur/blob/main/src/engine/Graphics/Graphic.ts#L60

Additionally we should drop a new tsconfig targeting this directory to incrementally shore up types.

eonarheim added a commit that referenced this issue Jul 5, 2024
@eonarheim
fix: [#3119] Fix graphics type + apply strictness to Graphics types
4f94423
@eonarheim eonarheim mentioned this issue Jul 5, 2024
Merged
5 tasks
@eonarheim eonarheim mentioned this issue Nov 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: [#3119] Fix graphics type + apply strictness to Graphics types excaliburjs/Excalibur
2 participants
@raylu @eonarheim