Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camera zoom over time does not work #800

Closed
eonarheim opened this issue Apr 29, 2017 · 0 comments
Closed

Camera zoom over time does not work #800

eonarheim opened this issue Apr 29, 2017 · 0 comments
Assignees
@eonarheim
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Milestone
0.11.0 Release

Comments

@eonarheim
Copy link
Member

Steps to Reproduce

Zoom over time is broken. However, instantaneous zoom still works.

// nothing happens, it should zoom in 2x over 3000 milliseconds
game.currentScene.camera.zoom(2, 3000);

Expected Result

The camera should zoom in X times over a specified time in milliseconds.

Actual Result

The camera does not zoom over time.

Proposal

There is a fix in the ludum-dare-38 branch, but it will need tests and more validate. It worked well enough for the ludum-38 game 860fe26
@eonarheim eonarheim added the bug This issue describes undesirable, incorrect, or unexpected behavior label Apr 29, 2017
@eonarheim eonarheim added this to the 0.11.0 Release milestone Apr 29, 2017
@eonarheim eonarheim mentioned this issue May 27, 2017
Merged
@eonarheim eonarheim mentioned this issue Jun 10, 2017
Closed
eonarheim added a commit that referenced this issue Jun 10, 2017
@eonarheim
[#800] Fix camera zoom over time (#827)
e69dfe2 
Closes #800 

## Changes:

- Implement missing camera zoom over time
- Zoom now returns a promise on completion
- Visual test demonstrating zoom
- Unit test validating zoom over time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eonarheim eonarheim

Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Milestone
0.11.0 Release
Development

No branches or pull requests
1 participant
@eonarheim