Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excalibur console message should automatically update for release #838

Closed
jedeen opened this issue Jun 11, 2017 · 2 comments
Closed

Excalibur console message should automatically update for release #838

jedeen opened this issue Jun 11, 2017 · 2 comments
Labels

Comments

@jedeen
Copy link
Member

jedeen commented Jun 11, 2017

Excalibur 0.11.0 does not show the correct label in the browser console (0.10.0 does, but this was prior to our automatic version proliferation).

Steps to Reproduce

npm install excalibur@0.11.0

then

var game = new ex.Engine({
    width: 800,
    height: 600
});
game.start();

Check the "Powered by Excalibur.js" text in the browser console.

Expected Result

"Powered by Excalibur.js (v0.11.0)"

Actual Result

image

Environment

  • browsers and versions: Google Chrome 58.0.3029.110 (64-bit), Mozilla Firefox 53.0.3 (32-bit), Microsoft Edge 40.15063.0.0
  • operating system: Windows 10 Pro
  • Excalibur versions: 0.11.0
@jedeen jedeen added the tools label Jun 11, 2017
@jedeen jedeen added this to the 0.12.0 Release milestone Jun 11, 2017
@kamranayub
Copy link
Member

kamranayub commented Jun 11, 2017

Thinking about this--this gets substituted at build time, the core repo gets built, then it commit+pushes to the dist repo. I believe the way to handle this through the automation in #777 is to ensure we substitute the right version before we scaffold a release/tag in the dist repo. We can detect that we are building a tag in Travis.

To fix it currently, @eonarheim could patch the tag and re-publish over 0.11 or issue a patch release tag (0.11.1).

@jedeen jedeen modified the milestones: 0.12.0 Release, 0.13.0 Release Jul 28, 2017
@kamranayub
Copy link
Member

Should be done by #867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants