Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Travis Git tag version if available #867

Merged
merged 3 commits into from
Aug 12, 2017
Merged

Use Travis Git tag version if available #867

merged 3 commits into from
Aug 12, 2017

Conversation

kamranayub
Copy link
Member

@kamranayub kamranayub commented Aug 12, 2017 •
edited
Loading

Related to #777
Closes #838

This will accomplish ensuring the dist files have the correct tagged version for release builds.

Changes:

  • Use Travis Git tag as version if available

@kamranayub kamranayub requested a review from jedeen August 12, 2017 19:13
jedeen
jedeen approved these changes Aug 12, 2017
View reviewed changes
Copy link
Member

@jedeen jedeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🗡

@kamranayub kamranayub merged commit 13b3f9b into master Aug 12, 2017
@kamranayub kamranayub deleted the 777-gh-tag branch August 12, 2017 19:21
@kamranayub kamranayub mentioned this pull request Aug 12, 2017
Closed
@jedeen jedeen added this to the 0.12.0 Release milestone Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedeen jedeen jedeen approved these changes

Assignees
No one assigned
Labels
tools
Projects
None yet
Milestone
0.12.0 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@kamranayub @jedeen