Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1512] WIP Add basic KeyboardScope #1531

Closed
wants to merge 1 commit into from
Closed

[#1512] WIP Add basic KeyboardScope #1531

wants to merge 1 commit into from

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented May 3, 2020 •
edited
Loading

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Partial fix #1512

Changes:

  • Add KeyboardScope option to Engine similar to PointerScope

@jedeen jedeen marked this pull request as draft May 11, 2020 15:53
@github-actions
Copy link

This PR hasn't had any recent activity lately and is being marked as stale automatically.

@github-actions github-actions bot added the stale This issue or PR has not had any activity recently label Dec 27, 2020
@eonarheim
Copy link
Member Author

Close for now, does not work as intended

@eonarheim eonarheim closed this Jan 9, 2021
@eonarheim eonarheim deleted the partial-bugfix/1512-keyboard-scope branch September 6, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale This issue or PR has not had any activity recently
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Add KeyboardScope option
1 participant
@eonarheim